Hi Luke, On Thu, 10 Jun 2021, Luke Shumaker wrote: > On Thu, 10 Jun 2021 03:13:29 -0600, > Johannes Schindelin via GitGitGadget wrote: > > This particular condition, however, was never tested on Windows, > > I was going to say that I do have CI set up[0] to run the subtree > tests on Windows, and was going to ask for assistance in figuring out > how to set up CI's Windows to match the behavior that you're seeing > with Cygwin. > > However, upon closer inspection: Because of how run-test-slice.sh > works, it wasn't actually running the subtree test on Windows. Oops. Right, I am sorry about that, it did bite me recently, too. > Now, that CI setup was just on my personal copies and hadn't been > submitted upstream, since I wasn't sure if it was welcome[1]. I never > really got a reply to that part, but but now that we've got buy-in > from Ævar for running the tests in contrib/,[2] I might spend some > more time on it and try to get that submitted. I am not so sure about running tests in contrib/ as part of the CI. Those bits and pieces are in contrib/ to indicate that they should _not_ be considered as adding to Junio's maintenance burden, and adding them to CI would contradict that. Having said that, in _Git for Windows_, we do bundle `git subtree`. Therefore, I would be interested in running its tests as part of CI because it is part of _my_ maintenance burden. As to your 30-strong patch series: Sorry, I really cannot afford even looking at such a large patch series. There are only 24h in a day, I need to sleep from time to time, and there is a pandemic raging on, and the Git mailing list's current atmosphere requires more self-care time from me that I need to spend elsewhere. But _if_ I had time to even look at it, I would suggest to first spend time to turn it into a full-fledged built-in in Git. I.e. move it from contrib/ to builtin/, rewriting it in C in the process. Please take that suggestion with a large rock of salt, though: as I said, I don't have time to assist in that endeavor, unfortunately not even as a reviewer. Ciao, Dscho > > [0]: https://github.com/LukeShu/git/commit/359c71be69749621125181b9d8c109baba6bf745 > [1]: https://lore.kernel.org/git/20210426174525.3937858-1-lukeshu@xxxxxxxxxxx/ > [2]: https://lore.kernel.org/git/87o8d0o2or.fsf@xxxxxxxxxxxxxxxxxxx/ > > -- > Happy hacking, > ~ Luke Shumaker >
