On Thu, Jun 3, 2021 at 4:55 AM Jonathan Tan <jonathantanmy@xxxxxxxxxx> wrote: > I don't think this is related to avoiding errno and conveying error > information through an out param. But besides that, as it is, I'm not > sure that this is correct. Even if EINVAL is not checked by the caller, > setting errno to EINVAL here means avoiding exposing a potential > EISDIR/ENOTDIR that a preceding call set. Same comment for the other > instances. You are right, but it's probably moot, because the follow-up commit stops using errno (making it impossible for EISDIR/ENOTDIR to haphazardly appear), but I dropped this commit from the series. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
