Re: [PATCH 2/4] *: use singular they in comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 7 Jun 2021, Ævar Arnfjörð Bjarmason wrote:

> On Mon, Jun 07 2021, Derrick Stolee via GitGitGadget wrote:
>
> > From: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
> >
> > Several comments in our code refer to an anonymous user with "he/him" or
> > "she/her" pronouns, and the choice between the two is arbitrary.
> >
> > Replace these uses with "they/them" which universally includes all
> > potential readers.
> >
> > Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
> > ---
> >  commit.c                                 | 2 +-
> >  config.h                                 | 2 +-
> >  contrib/hooks/multimail/git_multimail.py | 4 ++--
>
> We should not change upstream projects we pull in like that, see
> README.Git in that directory +
> https://github.com/git-multimail/git-multimail.

It is probably a good idea to make that upstream project not only the
authoritative source, but the only source. In other words, I think we
should replace the files in `contrib/hooks/multimail/` by a `README` that
points to the indicated URL.

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux