Junio C Hamano wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > > > SZEDER Gábor wrote: > >> On Sun, Jun 06, 2021 at 01:47:25PM -0500, Felipe Contreras wrote: > >> > Otherwise commands like 'for-each-ref' are not completed. > >> > >> I think you meant that options of commands like 'for-each-ref' are not > >> completed. > >> ... > > > Yes, I meant commands like 'for-each-ref' are not completed correctly... > > by __gitcomp_builtin. Which in practical tearms means what you just > > described above. > > I couldn't exactly tell if that's a roundabout way to say "yes, > yours is better and I'll use it in an update, thanks". I meant that I meant what he said I meant. But meaning is not saying, and it's better to say what one means (implied), and since Szeder's version says what I meant, that's better. > I'll assume that is the case and will mark the topic as expecting the > final update (as it seemed that all the other patches in the series > were received favourably). I think it would be trivial to do s/commands/options of &/ when merging the series, but fine, I'll reroll. > Or was it meant as "no, the version you commented on was already > correct (if you squint your eyes)"? No, that's not what I meant. -- Felipe Contreras
