On Wed, Jun 02 2021, Junio C Hamano wrote: > René Scharfe <l.s.r@xxxxxx> writes: > >>> On AIX under both bash and ksh this test breaks because "pwd -P" will >>> happily display the current working directory, but getcwd(3) called by >>> the "git init" we're testing here will fail to get it. >>> >>> I checked whether clobbering the $PWD environment variable would >>> affect it, and it didn't. Presumably these shells keep track of their >>> working directory internally. >>> >>> Let's change the test to a new "test-tool getcwd". >> >> Makes sense. >> >> If /bin/pwd can figure out the path to the current working directory >> without read permissions to parent directories then it might be possible >> to teach strbuf_getcwd() the same trick, though. How does it do it? >> ... >> If strbuf_getcwd() were to learn any of these tricks, then so would >> "test-tool getcwd", via its xgetcwd() call. At that point we'd better >> rename GETCWD_IGNORES_PERMS to XGETCWD_IGNORES_PERMS. >> >> But I guess we need none of that because we never got a request from >> an AIX user to support a /home directory without read permissions, >> right? > > Nice "thinking aloud". I see (well, rc/release period and all) that you didn't pick this up. I think per my just-sent http://lore.kernel.org/git/871r9d6hhy.fsf@xxxxxxxxxxxxxxxxxxx that it makes sense to just leave this at s/pwd(1)/getcwd(3)/ as this patch does.
