On Fri, Jun 4, 2021 at 11:40 PM Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote: > > Hi, > > On 05/06/21 00.43, Matthew Rogers via GitGitGadget wrote: > > This pull request comes from our discussion here[1], and I think these > > patches provide a good compromise around the concerns discussed there > > > > 1: > > https://lore.kernel.org/git/CAOjrSZusMSvs7AS-ZDsV8aQUgsF2ZA754vSDjgFKMRgi_oZAWw@xxxxxxxxxxxxxx/ > > > > CCing the people involved in the original discussion. > > This focused on improving CMake support, especially on Visual Studio, right? > > Then so we have three ways to build Git: > 1. plain Makefile > 2. ./configure (really just wrapper on top of Makefile) > 3. generate build file with CMake > > If we want to support all of them, it may makes sense to have CI jobs > that perform build with each options above. > > -- > An old man doll... just what I always wanted! - Clara Here's my understanding of the current pipeline situation: I know the Visual Studio CMake generator is currently used to build on Windows for gitgitgadget[1]. I'm not sure how worth it it would be to add another pipeline just to test if we correctly set EXPORT_COMPILE_COMMANDS=TRUE on by default correctly. I think adding support for running cmake builds on linux is a bit of a waste since those platforms should have ready access to make, and that's the build method that gets the official support. I don't really have much more of a position on this other than "Probably not worth it to add a cmake build on linux" 1: https://github.com/gitgitgadget/git/runs/2748313673 -- Matthew Rogers
