RE: [PATCH v4] contrib/completion: fix zsh completion regression from 59d85a2a05

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Aguilar wrote:
> A recent change to make git-completion.bash use $__git_cmd_idx
> in more places broke a number of completions on zsh because it
> modified __git_main but did not update __git_zsh_main.

You might want to try this in the future to reference previous commits:

  % git show --quiet --format=reference
  59d85a2a05 (git-completion.bash: use $__git_cmd_idx in more places, 2021-04-22)

(one of the aliases I'm missing right now)
  
> Suggested-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
> Signed-off-by: David Aguilar <davvid@xxxxxxxxx>

I have not tested this particular version, but I have tested similar
changes, and this should work:

Acked-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>

-- 
Felipe Contreras



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux