On 6/1/2021 2:14 PM, Emily Shaffer wrote: > On Fri, May 28, 2021 at 02:11:02PM +0200, Ævar Arnfjörð Bjarmason wrote: >> >> After suggesting[1] an another round that the config-based-hook >> topic[2] should take a more incremental approach to reach its end goal >> I thought I'd try hacking that up. I think sending this complete reorganization of a long-lived topic is not helpful, especially because the end-to-end diff is significant. This series has been extensively tested and incrementally improved for months, and it would be a waste to start over and lose all of that hardening. It's also a but rushed that this comes only a day after the previous message recommending a reorganization. It would be best to at least give the original author an opportunity to comment on your idea before working on this. >> So this is a proposed restart of that topic which if the consensus >> favors it should replace it, and the config-based hooks topic should >> be rebased on top of this. > > I'm not entirely sure what you're trying to achieve by sending this > series. It was my impression that the existing config-based-hooks topic > was close to being ready to submit anyway (since Junio mentioned > submitting it a couple revisions ago); rather than churning by reviewing > a different 31-patch topic, and then re-rolling and re-reviewing a > (reduced) config hook topic, wouldn't it be easier on everyone's time to > do a final incremental review on the existing topic and then start in on > bugfixes/feature patches afterwards? I completely agree here. > It would have been nice to see a more clear discussion of patch > organization sometime much sooner in the past year and a half since the > project was proposed[3], like maybe in the few iterations of the design > doc which included a rollout plan in July of last year[4]. To me, it > seems late to be overhauling the direction like this, especially after I > asked for opinions and approval on the direction before I started work > in earnest. I've also seen messages as early as January where Ævar mentioned wanting to review the series, but not finding the time to do so. It is reasonable to expect that contributors attempt such major reorganizations according to reviewers feedback, as long as the reviewers are timely about delivering that feedback. Thanks, -Stolee
