Jeff King <peff@xxxxxxxx> writes: > On Mon, May 31, 2021 at 06:15:00AM +0900, Junio C Hamano wrote: > >> There however is one curious thing about this. The log message of >> the original commit that introduced this optimization does use the >> batch-check and batch-all-objects at the same time. Was this >> breakage not there when the original was written and we broke it in >> a later update? If so, with what commit? Can that commit have >> broken other places in cat-file in a similar manner? > > The subtlety here is that it is broken with --batch, not --batch-check. > Only the former calls print_object_or_die(), which is after all the > difference between the two. :) > >> [...] > > Everything else you noted was quite reasonable, but I think we can get > further at the root of the issue; see my other email. Yup, I missed the place we depend on type being set without checking.
