Junio C Hamano wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > > > `simple` is the most important mode so move the relevant code to its own > > function to make it easier to see what it's doing. > > The change and the above description makes sense to me. > > I didn't, and still don't, understand the use of verb "to hedge" in > the title, though. > Apparently it isn't "to evade the risk of > commitment", "to protect oneself finantially", and of course not "to > plant, form, or trim a hedge". Those appear to be the intransitive verb definitions of Merriam-Webster [1], there's an object in the sentence (code), so it's the transitive ones that are applicable: * to enclose or protect with or as if with a dense row of shrubs or low trees: ENCIRCLE * to confine so as to prevent freedom of movement or action Some synonyms: block, border, cage, confine, coop, corral, edge, fence, restrict, ring, surround. I think it fits. > > Reviewed-by: Elijah Newren <newren@xxxxxxxxx> > > I trust Elijah would complain and/or clarify if this footer is > inappropriate (I didn't see an explicit "You can have my > Reviewed-by", but only "this looks good to me", and didn't know > what he meant). But he did review the entire series. So I think it's safe to say he reviewed this patch. > I do like the change of the phrasing from triangular to same-remote > at the end of the extended series, by the way. It makes the code > simpler to read and much easier to reason about, and it would be > nice to have it even before this step ;-) All right, I'll keep in mind for the next round. Cheers. [1] https://www.merriam-webster.com/dictionary/hedge -- Felipe Contreras
