Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > The "comments-by" sub-thread looked unproductive to me, so I mostly > > skipped it. ;) But as the person whose name was in the trailer, I will > > say that I do not care either way if it is included. It did not seem to > > add anything to me. Some trailers are good for pointing later readers to > > folks who may be able to help understand or debug an old commit. Some > > are good for just giving credit to people who helped. "Comments-by" > > didn't really seem to do either to me (and I don't feel like I > > contributed much worthy of credit anyway). > > Exactly the same feeling. It didn't add any value that was why I > saw no point in using something almost nobody uses (instead of the > more commonly used Helped-by, for example). As I demonstrated with probabilistic certainty; everyone uses uncommon lines (including you). The fact that a line is uncommon doesn't necessarily mean it's bad, in fact, I do see value in going outside the box (like one of my favorites: Brown-paper-bag-fixes-by [4981fe750b]). And of course if you find Comments-by so egregious, you can amend my commit message (as you have done many times in the past). But this might be a good opportunity to exercise the advice Jeff gave in another thread, and even if you are not 100% happy with something, let it slide. Cheers. -- Felipe Contreras
