On Thu, May 20, 2021 at 6:35 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > I looked this all over and left some nits, suspect/probably/definite bug > comments on specific patches, the ones with no comments from me LGTM. Awesome. Thanks for reviewing. I'll try to go over your comments this week. > I intentionally didn't review my own earlier feedback on v1 to look at > this with fresh eyes, I'd forgetten what points I raised, aside from the > general "let's not skip tests but test the new behavior" mantra I think > I either mentioned there or in related discussions. "test new behavior" is troublesome, because it requires merging the reftable support first, which in itself is a tough job, and predicated on getting reviews for that code. This is why I split this series off, because it can be merged early without impacting coverage of the existing loose/packed backend. How about I document more clearly, for each test marked REFFILES, what is going on, and what should be done for coverage with reftable? We can go over it as part of the reftable series. "REFFILES" will be an easy term to grep for. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
