Junio C Hamano <gitster@xxxxxxxxx> writes: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> Apparently my scripts call `git format-patch` with -D, which doesn't >> generate appliable patches when files are deleted. > > Don't call format-patch with -D, then ;-). > >> Do you want me to send it again without -D? > > Sure, if a collection of patches want to be reviewed and applied, I > would think it helps for them to be appliable to a common tree (like > my 'master') with tools reviewers and the maintainer are know to use > (like "git am"). As more roadblocks are added before the changes > can become reviewable in the reviewers' trees, less chances they > have to get reviewed. Oh, I didn't answer the question. Do I want you (or anybody) to? Not really, especially during the pre-release freeze period. I wasn't heavily involved in the "let's use asciidoctor-native to bypass xmlto" or "asciidoc is not exactly abandoned, but we should prepare ourselves to make asciidoctor the default" discussion, but I've seen people I trust voice their opinion and trust them enough to believe that a concensus among them would lead to an acceptable future, so I'd rather stand on the sideline, and see people discuss and come up with a concensus before I pick the final product when the next cycle opens. And it would help to make sure reviewers can pick it up and apply it to their trees, if a patch series, even as a discussion material and not a final submission, wants to lead to such a concensus. Thanks.
