Hi, Johannes Sixt wrote: > Git for Windows is a native Windows program that works with native > absolute paths in the drive letter style C:\dir. The auxiliary > infrastructure is based on MSYS2, which uses POSIX style /C/dir. [nice explanation snipped] > Signed-off-by: Johannes Sixt <j6t@xxxxxxxx> > --- > When I say "the configuration is transformed to /C/dir style", I am > actually hand-waving: I can observe that a transformation must > happen somewhere, but I actually do not know where the conversion > really happens. "The MSYS2 layer" is my best qualified guess. Thanks. The explanation is appreciated --- it helps avoid the feeling of randomness involved. Hopefully some day our test setup will allow doing everything at the "native Windows program" level (well, I can hope). [...] > --- a/t/t9001-send-email.sh > +++ b/t/t9001-send-email.sh > @@ -539,15 +539,14 @@ test_expect_success $PREREQ "--validate respects relative core.hooksPath path" ' > test_path_is_file my-hooks.ran && > cat >expect <<-EOF && > fatal: longline.patch: rejected by sendemail-validate hook > - fatal: command '"'"'$(pwd)/my-hooks/sendemail-validate'"'"' died with exit code 1 > + fatal: command '"'"'$PWD/my-hooks/sendemail-validate'"'"' died with exit code 1 > warning: no patches were sent > EOF > test_cmp expect actual Ideally we wouldn't have to check the exact output at all. Is there a reason we care about the absolute path being echoed on error? [...] > test_expect_success $PREREQ "--validate respects absolute core.hooksPath path" ' > - hooks_path="$(pwd)/my-hooks" && > - test_config core.hooksPath "$hooks_path" && > + test_config core.hooksPath "$(pwd)/my-hooks" && > test_when_finished "rm my-hooks.ran" && > test_must_fail git send-email \ > --from="Example <nobody@xxxxxxxxxxx>" \ > @@ -558,7 +557,7 @@ test_expect_success $PREREQ "--validate respects absolute core.hooksPath path" ' > test_path_is_file my-hooks.ran && > cat >expect <<-EOF && > fatal: longline.patch: rejected by sendemail-validate hook > - fatal: command '"'"'$hooks_path/sendemail-validate'"'"' died with exit code 1 > + fatal: command '"'"'$PWD/my-hooks/sendemail-validate'"'"' died with exit code 1 > warning: no patches were sent > EOF > test_cmp expect actual Likewise. That said, the patch as is is Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> Thanks.
