Re: [PATCH v4] help: colorize man pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Phillip Wood wrote:
> On 20/05/2021 16:59, Felipe Contreras wrote:
> > Phillip Wood wrote:
> >> On 20/05/2021 14:58, Felipe Contreras wrote:

> >>> That is true. We could add a check for that:
> >>>
> >>>     if (getenv("LESS_TERMCAP_md"))
> >>>             return;
> >>>
> >>> However, it may not be necessary since many of the tips online set these
> >>> variables inside a function.
> >>
> >> The only person who has tested this patch has reported a problem with
> >> it, it seems unlikely that no other users will have similar issues.
> > 
> > The check above will fix your problem, will it not?
> 
> Yes it will if it is implemented which was not clear as your message 
> suggested it may not be necessary.

It was a maybe.

> I think it would be safer to check LESS_TERMCAP_{md,us,so} and not set
> LESS if any of them are set as it is possible a user may only override
> some of them.

Sure, if we could set 6 variables before, we can check for 3 afterwards.

-- 
Felipe Contreras



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux