From: Bagas Sanjaya <bagasdotme@xxxxxxxxx> Sent: 20 May 2021 12:33 Subject: Re: [PATCH v3 02/13] Documentation/technical: describe remembering renames optimization On 20/05/21 13.09, Elijah Newren via GitGitGadget wrote: > +Outline: > + > + 0. Assumptions > + > + 1. How rebasing and cherry-picking work > + > + 2. Why the renames on MERGE_SIDE1 in any given pick are *always* a > + superset of the renames on MERGE_SIDE1 for the next pick. > + > + 3. Why any rename on MERGE_SIDE1 in any given pick is _almost_ always also > + a rename on MERGE_SIDE1 for the next pick > + > + 4. A detailed description of the the counter-examples to #3. > + > + 5. Why the special cases in #4 are still fully reasonable to use to pair > + up files for three-way content merging in the merge machinery, and why > + they do not affect the correctness of the merge. > + > + 6. Interaction with skipping of "irrelevant" renames > + > + 7. Additional items that need to be cached > + > + 8. How directory rename detection interacts with the above and why this > + optimization is still safe even if merge.directoryRenames is set to > + "true". > + For item 1, 2, 3, 5, 8, it seems that you form question sentences but ended with dot, instead of question mark (?). Are these question sentences or descriptive sentences? [RK] Not so. [RK] These are all "How the leopard changed his spots. [RK] Not "How dd the leopard change his spots ?" which of course does need the question mark. [RK] They are not sentences, but headings.
