On Thu, May 20, 2021 at 9:14 AM ZheNing Hu <adlternative@xxxxxxxxx> wrote: > > Christian Couder <christian.couder@xxxxxxxxx> 于2021年5月18日周二 下午10:32写道： > > > 2. "50cfe1f([GSOC] ref-filter: introduce enum atom_type)" has > > > been merged into the `next` branch, should we focus on the > > > performance optimization of `ref-filter.c`? Finally, we can build a > > > `format_cat_file_item()` similar to `format_ref_array_item()`, > > > which should not be difficult. And we have to make sure that the > > > performance of `cat-file --batch` is not lower than before. > > > > I wonder if format_ref_array_item() could not just be used by > > batch_object_write() like Olga did it in: > > > > https://github.com/git/git/pull/568/commits/f911b342ae6503dc9f6f8e3c7df316aa45d97bdf > > Thanks for the tip! Olga uses `format_cat_file_item()` in You mean `format_ref_array_item()` not `format_cat_file_item()`, right? > batch_object_write() , which may be the correct approach. > Before that, we have to make ref-filter support "%(contents:raw)" > (similar to Olga's "%(raw)") and "%(rest)". Yeah, please take a look, if you haven't already, at https://github.com/git/git/pull/568 where Olga already worked on that. It would likely help if you can reuse her work.
