On Wed, May 19 2021, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> So you might expect it to accept an --allow-unknown-type, but it >> doesn't. I could add support for that, but I think it would be stupid. >> >> Why should you need to restart a "cat-file --batch" just because you >> encounter a bad object? Just .. print it, we can do that safely. I >> really don't see the point of having --allow-unknown-type at all. Ditto >> for the --batch-check mode. >> >> I mean, having read all the code I think I know why it's there. I think >> It's because there was no way to ferry the information up from >> object-file.c before my yet-to-be-submitted patches, so the solution was >> to pass down a flag saying "please don't die()". >> >> But is it something that anyone thinks is a good idea in the abstract? I >> don't see why I shouldn't just document something like: >> >> Older versions of "cat-file" used to require an --allow-unknown-type >> flag to emit information about objects of unknown types. This is no >> longer required or the default. If you'd like to die on anything >> except known types (e.g. to die instead of bothering with parsing a >> "bad" type that possibly has spaces in it in the --batch output) >> supply --no-allow-unknown-type. >> >> What do you think? > > Thanks for thinking things through. > > My knee-jerk reaction is > > - As long as "cat-file -t $thing" exits with non-zero status for an > invalid thing, which was crafted using hash-object --literally, > reporting the typename it read from the object header to its > standard output would be fine without "--allow-unknown-type". > But scripts would be upset if it suddenly started to return with > zero status when asked to check what type of object the $thing > is. That feels even weirder to me. Why conflate the "this is naughty object" with "we successfully inspected it"? I don't think cat-file should be exiting non-zero unless it actually has an error inspecting the object. But in terms of implementation that's trivial, just look if the object is on the whitelist of types before exiting. It's certainly less hassle than what it's currently doing. I was thinking something like an advise() to stderr at most when we emitted one of these: > - For "cat-file --batch[-check]", I am on the fence. A script may > break because it is not prepared to see anything but four > existing types (so it might even say "do X if it is a blob, do Y > if it is a tree, do Z if it is a tag, and do W for everything > else" and expect/assume that W will see only commits), so failing > without --allow may still be a prudent thing to do. We could > declare that such a script is already broken, even though it > would not change the fact that the user has been successfully > using it reliably. The main reason I even care about this was the fsck case, and it looking up and down the callstacks from OBJECT_INFO_ALLOW_UNKNOWN_TYPE I think we're needlessly worrying about this in the cat-file case. I think even in the case you mentioned a script would be better off with a default of --allow-unknown-type. Right now if you somehow fed it an object with such a type it would just hard die, whereas after you could proceed to feed it other objects. But realistically (and I may be wrong here) I don't think we need to worry about backwards compatibility with --allow-unknown-type at all. I'm fairly certain nobody's dealing with these objects in the wild except git's own test suite. No server implementation will accept them, you can't even push/pull them locally. It's just there for completeness with "hash-object --literally": https://lore.kernel.org/git/54EDACC9.5080204@xxxxxxxxx/ So I think it's fine just to say it was a mistake to require opt-in options to *inspect* such naughty objects, as opposed to creating them (where we should have the opt-in --literally option). > With your new "we can now bubble necessary information up from the > object-file.c layer without dying" change, it might make it easier > to arrange so that object-file.c layer would never die and I do not > think I have any objection against such a plan. The implementation > of "--[no-]allow-unknown-type" would have to be migrated to the > caller at the higher level to decide what to do when it learns that > the object it asked the object_info() about is of an invalid type. > And the choice of the default would become easier to change later > with such a change to the lower layer. For what it's worth the new API is just passing OBJECT_INFO_ALLOW_UNKNOWN_TYPE to oid_object_info_extended() along with the (existing) "typep". You then see if the typep is < 0. > But I am not sure if that warrants switching of the default. Hopefully either this thread or a re-roll of that series will convince you, is this something you'd like to see on list in the next few days or is it better to hold off until after the RC period? Another thing I didn't mention as a reason for getting rid of --allow-unknown-type is that part of the patches I was hacking up made various read-only commants behave sensibly in the face of these badly typed objects, where now they'll just die. E.g. Jeff King's recent --disk-usage for rev-list will just die on it, since we call "what is the type of this" without OBJECT_INFO_ALLOW_UNKNOWN_TYPE somewhere. I think it's a much better approach to just implicitly supply a OBJECT_INFO_ALLOW_UNKNOWN_TYPE at a high level (you just want the total disk use, who cares if there's one bad object there), as opposed to teaching rev-list and others about --allow-unknown-type.
