On Mon, May 17, 2021 at 12:44 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Derrick Stolee <stolee@xxxxxxxxx> writes: > > > On 5/12/2021 1:28 PM, Derrick Stolee via GitGitGadget wrote: > >> From: Derrick Stolee <stolee@xxxxxxxxx> > >> > >> The documentation comment for treat_directory() was originally written > >> in 095952 (Teach directory traversal about subprojects, 2007-04-11) > >> which was before the 'struct dir_struct' split its bitfield of named > >> options into a 'flags' enum in 7c4c97c0 (Turn the flags in struct > >> dir_struct into a single variable, 2009-02-16). When those flags > >> changed, the comment became stale, since members like > >> 'show_other_directories' transitioned into flags like > >> DIR_SHOW_OTHER_DIRECTORIES. > >> > >> Update the comments for treat_directory() to use these flag names rather > >> than the old member names. > >> > >> Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > >> Reviewed-by: Elijah Newren <newren@xxxxxxxxx> > > > > I think you want the "Reviewed-by" before the "Signed-off-by", > > followed by your own sign-off. > > Grabbing somebody else's signed-off patch, and forwarding it (with > or without tweaks and enhancements) with your own sign-off would be > a sufficient sign that you've inspected the patch deeply enough to > be confident that it is worth forwarding. So I think you can even > lose the reviewed-by. > > But as long as you are relaying somebody else's patch, DCO asks you > to sign it off yourself. > > Thanks. I was going to go fix this up, but it looks like en/dir-traversal has already merged down to next. We could revert the last two patches of the series out of next (allowing the first seven with the important fixes to merge down) and then I could resubmit just the last two patches. Or we could just let them all merge down as-is. Preferences?
