On 5/13/2021 12:12 AM, Elijah Newren wrote: > On Fri, Apr 23, 2021 at 2:34 PM Derrick Stolee via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: >> >> This is the first "payoff" series in the sparse-index work. It makes 'git >> status' very fast when a sparse-index is enabled on a repository with >> cone-mode sparse-checkout (and a small populated set). > > I read through the topic, both my old comments, the range-diff, and > the new patches where the range-diff wasn't enough. I tried to spot > issues, and was hoping to find problems you alluded to in your recent > comments at https://lore.kernel.org/git/05932ebc-04ac-b3c5-a460-5d37d8604fd9@xxxxxxxxx/, > but I failed to spot them. I hope it has to do with the cache bottom > stuff that I just don't understand, because otherwise I just missed > the problems in my review. I can say that in v2 you fixed the issues > I did spot in my review of v1. > > I'll look forward to v3 to see what it was I missed. If I somehow > don't respond soon (in a week at the latest), do feel free to ping me; > sorry for somehow having this one slip through the cracks. v3 is on the way. The changes related to issues I found in my deeper testing are more about what wasn't previously tested in my test script as opposed to things actually being wrong in the patch series. (There is one case where some new code was incorrect, but it wasn't being tested because of the test repo's data shape.) Thanks, -Stolee
