Junio C Hamano <gitster@xxxxxxxxx> wrote: > "Robert Newson" <robert.newson@xxxxxxxxx> writes: > > > The latest head of git gives me this when doing most operations, this > > also happens with the rc7 experimental Debian package. It's annoying > > because it prints this line hundreds of times for each call to 'log', > > for example > > > > "Use of uninitialized value in string eq at blah/git/git-svn line 826." > > > > and this fixes it; > > Curious. I wonder how can it trigger. > > Presimably, that while (<$fh>) loop is reading from git-log, and > the first line would look like "commit [0-9a-f]{40}" and will > set $hash, do "next". Which means the variable should have been > initialized by the time the part that complains about string eq > (which I think is "if ($c && $c eq $hash)" comparison) is > reached. This could be a sign of a bigger problem. Does git-log read .git/config and that could potentially change its default output format? A quick scan of the docs say "no". I remember using git-rev-list in the original code because git-log was (is still?) considered porcelain and less suitable for automated parsing... -- Eric Wong - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html