Re: [PATCH 7/8] doc: improve asciidoc dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 13 May 2021 at 00:28, Felipe Contreras
<felipe.contreras@xxxxxxxxx> wrote:
>
> asciidoc needs asciidoc.conf, asciidoctor asciidoctor-extensions.rb.
>
> Neither needs the other.

> -ASCIIDOC_DEPS = asciidoc.conf asciidoctor-extensions.rb GIT-ASCIIDOCFLAGS
> +ASCIIDOC_DEPS = asciidoc.conf GIT-ASCIIDOCFLAGS

> +ASCIIDOC_DEPS = asciidoctor-extensions.rb GIT-ASCIIDOCFLAGS

Thanks. I was a bit lazy in a15ef383e7 ("Documentation/Makefile: add
missing dependency on asciidoctor-extensions", 2019-02-27).

We end up with some duplication. We could pull GIT-ASCIIDOCFLAGS into
some ASCIIDOC_DEPS_COMMON. But with just one such common dependency, it
seems unnecessary and overly complicated. We can pull out the common
dependencies when we actually gain something from it.

Martin



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux