Junio C Hamano <gitster@xxxxxxxxx> 于2021年5月13日周四 上午7:11写道： > > "ZheNing Hu via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > From: ZheNing Hu <adlternative@xxxxxxxxx> > > > > Since "objectsize:size" is composed of two parts, > > "type:attribute". However, the original implementation > > Y is missing in the above "Since X, Y". Because it is composed of > two parts, what? > > Dropping "Since " would make the sentence work better. Also, I > think it should be "objectsize:disk". > Oh, here is my typo. > > did not decouple the two parts "type" and "attribute" well, > > we still need to judge separately whether the atom is > > "objectsize" or "objectsize:disk" in `grab_common_values()`. > > Perhaps > > When the support for "objectsize:disk" was bolted onto the > existing support for "objectsize", it didn't follow the > usual pattern for handling "atomtype:modifier", which reads > the <modifier> part just once while parsing the format > string, and store the parsed result in the union in the > used_atom structure, so that the string form of it does not > have to be parsed over and over at runtime (e.g. in > grab_common_values()). > That’s great. Thanks. -- ZheNing Hu
