Gregory Anders wrote: > On Wed, 12 May 2021 12:21 -0500, Felipe Contreras wrote: > >The sole purpose of software is that it's useful to users. Software > >that works today but not tomorrow is bad software. > > > >The primary purpose of the testing framework is to ensure that doesn't > >happen; that git keeps working in the same way today than it did > >yesterday. > > > >That's why it's more important that tests excercise the options people > >were using yesterday. > > > >In addition we also want to be testing new functionality, but that's *in > >addition*. > > > >Maybe at some point in the future more people will be using > >--sendmail-cmd, but right now that's not the case. Right now we need to > >be testing the option people are using *today*. > > I agree with this completely. Is this requirement satisfied with the > addition of a test that checks the usage of an absolute path with > --smtp-server (the behavior that people were using yesterday), while all > of the existing tests are still converted to the new option? I have such > a test written (along with a few others) in the forthcoming v2 patch: I still insist the current tests should not be converted. But ultimately it's Junio's call. Cheers. -- Felipe Contreras
