Elijah Newren <newren@xxxxxxxxx> writes: > If you'd like, I can add another patch in the series with this change > so that all readdir() calls in dir.c have such ignore '.' and '..' > logic. Or, we could perhaps introduce a new readdir() wrapper that > does nothing other than ignore '.' and '..' and have all three of > these callsites use that new wrapper. Yeah, it is good to be consistent (either implementation). >> So dropping the test for number of visited paths would be nicer from >> portability's point of view ;-) > > Yep, makes sense. I already did that in v4, which means it'll > continue to pass with or without the above proposed change to > read_cached_dir(). Yup.