On Wed, May 12, 2021 at 07:56:47AM +0900, Junio C Hamano wrote: > > IMHO this is a good path forward. There's a thread from a few months ago > > which talks about this idea: > > > > https://lore.kernel.org/git/YCvotU6KVruFuf9%2F@xxxxxxxxxxxxxxxxxxxxxxx/ > > > > There's some back and forth, and I'm not sure if I convinced Junio in > > the end. But certainly a patch would be a good way to restart the > > conversation. :) > > The argument is not just about configuration but applies equally to > its command line argument "--smtp-server=<what>", right? I think it > makes sense in both of these places. I further wonder if we should > allow not just a single token, but supplying an initial few arguments, > too, e.g. > > git send-email --smtp-server="/usr/bin/env msmtp" > git send-email --smtp-server="!my-msa --emulate-sendmail" Yes, the patch under discussion does apply to both the command-line option and the config option (and I agree it should). I didn't think about arguments, but you're right that may be a useful feature. And if done via the shell, as brian suggested elsewhere, would be more consistent with other parts of Git using "!" syntax. It does make things a little weird in that: git send-email --smtp-server='/path/to/my-sendmail foo' and git send-email --smtp-server '!my-sendmail foo' behave differently (the first does not work; it looks for an executable with a space in the name). -Peff
