Jeff King <peff@xxxxxxxx> writes: > On Mon, May 10, 2021 at 06:18:36AM +0200, Firmin Martin wrote: > >> > Looking at the second patch, the motivation here seems to be to use >> > git_prompt() for another run-of-the-mill prompt. But the right answer >> > is: don't do that. In fact, we recently-ish removed a similar case in >> > 97387c8bdd (am: read interactive input from stdin, 2019-05-20) that was >> > likewise causing problems with the test suite. >> >> I actually inspired myself from the two occurrences of git_prompt in >> builtin/bisect--helper.c introduced in 09535f056b (bisect--helper: >> reimplement `bisect_autostart` shell function in C, 2020-09-24). >> Not sure if they should also be converted to a simple fgets. > > Yes, I think they should be switched. OK, that is because in the context of a "bisect" session, we won't be feeding any real data from its standard input, unlike "git am" that may well be eating a patch stream from its standard input stream. If so, makes sense.
