On Mon, May 10, 2021 at 2:04 PM Phillip Wood <phillip.wood123@xxxxxxxxx> wrote: > On 09/05/2021 22:32, Lénaïc Huard wrote: > > +static int systemd_timer_enable_unit(int enable, > > + enum schedule_priority schedule, > > + const char *cmd) > > The cmd argument is pointless, it will always be "systemctl" and you > have even hard coded that value into the error message below. The reason that `cmd` is passed around everywhere is that the actual command can be overridden by GIT_TEST_MAINT_SCHEDULER which allows the test script to mock up a scheduler command rather than running the real scheduler command. I haven't read the new version of the patch closely yet, but after a quick scan, I'm pretty confident that this is still the case (despite the aggressive changes the patch makes to the areas around GIT_TEST_MAINT_SCHEDULER). As for hardcoding the command name in the error message, that seems perfectly fine since, under normal circumstances, it _will_ be that command (it's only different when testing).
