Junio C Hamano <gitster@xxxxxxxxx> writes:
> Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> writes:
>
>> +--original <namespace>::
>> + Use this option to set the namespace where the original commits
>> + will be stored. The default value is 'refs/original'.
>> +
>
> The default seems to be "refs/original/".
>
> Even worse.
>
> I think if you say --force --original refs/head (notice the lack
> of "s" nor slash at the end), the code will get you in a *lot*
> of trouble.
>
> Dscho, don't we want to do something like this?
>
> ---
> git-filter-branch.sh | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-filter-branch.sh b/git-filter-branch.sh
> index 0190060..a7f50a6 100755
> --- a/git-filter-branch.sh
> +++ b/git-filter-branch.sh
> @@ -134,6 +134,7 @@ do
> filter_subdir="$OPTARG"
> ;;
> --original)
> + case "$OPTARG" in */) ;; *) OPTARG="$OPTARG/" ;; esac
> orig_namespace="$OPTARG"
> ;;
> *)
orig_namespace="${OPTARG%/}/"
Sure, it does not win the "portable to Version 7" price, but our
scripts don't do that, anyway.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
