On 5/3/2021 12:10 PM, Andrzej Hunt wrote:
>
> On 15/10/2020 19:21, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
>> +static int run_command_on_repo(const char *path,
>> + void *cbdata)
>> +{
>> + int i;
>> + struct child_process child = CHILD_PROCESS_INIT;
>> + struct strvec *args = (struct strvec *)cbdata;
>
> I was curious there's a strong reason for declaring args as void * followed by this cast? The most obvious answer seems to be that this probably evolved from a callback - and we could simplify it now?
You are absolutely right that this evolved from a
callback. I look forward to reviewing your patch that
updates this. ;)
Thanks,
-Stolee
