On 4/8/21 9:09 PM, Jonathan Tan wrote: > A subsequent commit will need part, but not all, of the functionality in > process_acks(), so move some of its functionality to its sole caller > do_fetch_pack_v2(). As a side effect, the resulting code is also > shorter. > case FETCH_PROCESS_ACKS: > /* Process ACKs/NAKs */ > - switch (process_acks(negotiator, &reader, &common)) { Good riddance to this nested switch! I am unfamiliar with this code, but I believe these changes to be correct. Thanks, -Stolee