Luke Diamand <luke@xxxxxxxxxxx> writes:
>>>> def searchParent(self, parent, branch, target):
>>>> + for tree in read_pipe_lines(["git", "rev-parse",
>>>> + "{}^{{tree}}".format(target)]):
>>>> + targetTree = tree.strip()
>>>
>>> It looks very strange to run a commit that you expect a single line
>>> of output, and read the result in a loop. Doesn't git-p4.py supply
>>> a more suitable helper to read a single line output from a command?
>> You're absolutely right that this isn't very readable. I had a quick
>> look around for a function that reads a single-line response, but I'll
>> look again and come up with a clearer solution.
>
> I don't think there is one - git-p4 has lots of functions for calling
> `p4', but for calling git, it just uses Python's Popen() API.
OK. It just felt "strange", not "wrong", so I am OK with the
construct at least for now.
> There are existing tests for importing branches which should cover
> this. I don't know if they need to be extended or not, you might want
> to check.
>
> Looks good otherwise.
Thanks for a prompt review.
