On 4/1/2021 11:41 AM, Jeff Hostetler via GitGitGadget wrote:... > + /* > + * If the fsmonitor response and the subsequent scan of the disk > + * did not cause the in-memory index to be marked dirty, then force > + * it so that we advance the fsmonitor token in our extension, so > + * that future requests don't keep re-requesting the same range. > + */ > + if (istate->fsmonitor_last_update && > + strcmp(istate->fsmonitor_last_update, last_update_token.buf)) > + istate->cache_changed |= FSMONITOR_CHANGED; > + This could lead to extra index writes that don't normally happen in the case without the FS Monitor feature. I'm particularly sensitive to this because of my sparse-index work is trying to solve for the I/O cost of large indexes, but perhaps this cost is worth the benefit. I'll keep an eye out as I do performance testing. Thanks, -Stolee
