On 4/1/21 11:40 AM, Jeff Hostetler via GitGitGadget wrote: > From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx> > > Implement command options `--stop`, `--is-running`, `--query`, > `--query-index`, and `--flush` to control and query the status of a > `fsmonitor--daemon` server process (and implicitly start a server > process if necessary). > > Later commits will implement the actual server and monitor > the file system. As mentioned before, I think the "query", "query-index", and "flush" commands are better served in a test helper. Luckily, the implementation you give here seems rather straightforward and could fit into a test helper without a lot of duplicated boilerplate. That's a good sign for the API presented here. As a bonus, you could delay the implementation of those test helpers until they are going to be used in a test. Thanks, -Stolee
