On Fri, 23 Apr 2021 15:51:53 -0600, Eric Sunshine wrote: > > On Fri, Apr 23, 2021 at 3:43 PM Luke Shumaker <lukeshu@xxxxxxxxxxx> wrote: > > The formatting in t7900-subtree.sh isn't even consistent throughout the > > file. Fix that; make it consistent throughout the file. > > > > Signed-off-by: Luke Shumaker <lukeshu@xxxxxxxxxxx> > > --- > > diff --git a/contrib/subtree/t/t7900-subtree.sh b/contrib/subtree/t/t7900-subtree.sh > > @@ -23,26 +21,24 @@ subtree_test_create_repo() > > -check_equal() > > -{ > > +check_equal () { > > test_debug 'echo' > > test_debug "echo \"check a:\" \"{$1}\"" > > test_debug "echo \" b:\" \"{$2}\"" > > - if [ "$1" = "$2" ]; then > > + if [ "$1" = "$2" ] > > + then > > We prefer `test` over `[`, so it might make sense to update that, as > well, along with these other style cleanups. OK, I'll include that in this commit. -- Happy hacking, ~ Luke Shumaker