Hi ZheNing, On Fri, Apr 23, 2021 at 04:27:25PM +0000, ZheNing Hu via GitGitGadget wrote: > From: ZheNing Hu <adlternative@xxxxxxxxx> > > Add the placeholders %ah and %ch to format author date and committer > date, like --date=human does, which provides more humanity date output. I don't see a reason why this shouldn't exist, and the patch that you wrote below looks pretty good to me. To refresh my memory on if you had missed any spots, I followed 0df621172d (pretty: provide short date format, 2019-11-19) as an example. You did a fine job here, and I don't think this patch is missing anything. > Signed-off-by: ZheNing Hu <adlternative@xxxxxxxxx> > --- > [GSOC] pretty: provide human date format > > Reasons for making this patch: --date=human has no corresponding > --pretty option. > > Although --date=human with --pretty="%(a|c)d" can achieve the same > effect with --pretty="%(a|c)h", but it can be noticed that most time > formats implement the corresponding option of --pretty, such as > --date=iso8601 can be replaced by --pretty=%(a|c)i, so add > "--pretty=%(a|c)h" seems to be a very reasonable thing. Just to make sure I understand what you wrote: you're saying that the pretty formats "%ah" and "%ch" that you propose here could be achieved with --date=human and --pretty="%ad". Makes sense, but I agree that your point about --date=iso8601 having a built-in pretty atom makes the case for having "%ah" and "%ch". > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-939%2Fadlternative%2Fpretty_human-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-939/adlternative/pretty_human-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/939 > > Documentation/pretty-formats.txt | 2 ++ > pretty.c | 3 +++ > t/t4205-log-pretty-formats.sh | 6 ++++++ > 3 files changed, 11 insertions(+) > > diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt > index 45133066e412..9cdcdb8bb414 100644 > --- a/Documentation/pretty-formats.txt > +++ b/Documentation/pretty-formats.txt > @@ -190,6 +190,7 @@ The placeholders are: > '%ai':: author date, ISO 8601-like format > '%aI':: author date, strict ISO 8601 format > '%as':: author date, short format (`YYYY-MM-DD`) > +'%ah':: author date, human style There's no sorting here, so this place (at the bottom of the author-date placeholders) seems just as good as any. > '%cn':: committer name > '%cN':: committer name (respecting .mailmap, see > linkgit:git-shortlog[1] or linkgit:git-blame[1]) > @@ -206,6 +207,7 @@ The placeholders are: > '%ci':: committer date, ISO 8601-like format > '%cI':: committer date, strict ISO 8601 format > '%cs':: committer date, short format (`YYYY-MM-DD`) > +'%ch':: committer date, human style Likewise. The rest all looks good to me, too. Reviewed-by: Taylor Blau <me@xxxxxxxxxxxx> Thanks, Taylor
