On Wed, 21 Apr 2021 21:59:04 -0600, Eric Sunshine wrote: > On Wed, Apr 21, 2021 at 8:34 PM Luke Shumaker <lukeshu@xxxxxxxxxxx> wrote: > > The --signed-tags= option takes one of five arguments specifying how to > > handle signed tags during export. Among these arguments, 'strip' is to > > 'warn-strip' as 'verbatim' is to 'warn' (the unmentioned argument is > > 'abort', which stops the fast-export process entirely). That is, > > signatures are either stripped or copied verbatim while exporting, with > > or without a warning. > > > > Match the pattern and rename 'warn' to 'warn-verbatim' to make it clear > > that it instructs fast-export to copy signatures verbatim. > > > > To maintain backwards compatibility, 'warn' is still recognized as > > an undocumented alias. > > Maintaining backward compatibility is good; making it undocumented is > perhaps less than good. I understand the motivation for not wanting to > document it: if it's not documented, people won't discover it, thus > won't use it. However, we also should take into consideration that > there may be scripts and documentation in the wild which use `warn`. > If someone comes across one of those and wants to learn what it means, > they won't be able to if the documentation doesn't mention it at all; > they'll either have to consult the source code to find out its purpose > or post a question somewhere, hoping that someone knows the answer. Fair enough. My precedent was ee4bc3715f (fast-export: rename the signed tag mode 'ignore' to 'verbatim', 2007-12-03). I guess I'll document --signed-tags=ignore too, while I'm at it. -- Happy hacking, ~ Luke Shumaker
