On 4/19/2021 9:47 PM, Taylor Blau wrote: > The '--geometric=<n>' argument specifies that each pack must contain at > least 'n' times as many objects as the size of the next-largest pack. > The factor 'n' is customizable, but setting it to '2' is a sane default. > > Instead of making the factor a required argument, make the argument > optional with a default value of '2'. This flexibility is nice. > To ensure that the option is setup correctly, modify the most complex > test of t7703 to drop the explicit factor. Good testing. > --g=<factor>:: > ---geometric=<factor>:: > +-g=[<factor>]:: > +--geometric[=<factor>]:: > Arrange resulting pack structure so that each successive pack > - contains at least `<factor>` times the number of objects as the > - next-largest pack. > + contains at least `<factor>` (`2` if unspecified) times the > + number of objects as the next-largest pack. The parenthetical interrupts what `<factor>` means. Perhaps rearrange: Arrange resulting pack structure so that each successive pack contains at least `<factor>` times the number of objects as the next-largest pack. If `<factor>` is not specified, then `2` is used by default. Rest of the diff looks good. Thanks, -Stolee
