On Mon, Apr 19 2021, Patrick Steinhardt wrote: > +test_expect_success 'git --config-env with missing value' ' > + test_must_fail env ENVVAR=value git --config-env 2>error && > + test_i18ngrep "no config key given for --config-env" error && > + test_must_fail env ENVVAR=value git --config-env config core.name 2>error && > + test_i18ngrep "invalid config format: config" error > +' > + Nit: (not spotted on the first reading): s/test_i18ngrep/grep/. > test_expect_success 'git --config-env fails with invalid parameters' ' > test_must_fail git --config-env=foo.flag config --bool foo.flag 2>error && > test_i18ngrep "invalid config format: foo.flag" error &&