Hi everyone,
while fixing some Unicode problems in a project, I noticed that gitk
will not display Unicode characters correctly and may even crash if the
branch name consists of Unicode characters.
I'ts certainly not the end of the world (who is crazy enough to use 🖤
as a branch name) but could still cause problems.
Please find some additional information below.
Best regards,
Lars
What did you do before the bug happened? (Steps to reproduce your issue)
- Create a git branch named with a multi-byte Unicode character like:
git checkout -b 🖤
- Launch gitk
- Crash (see below)
- Switch to another branch
git checkout xy
- Launch gitk
- Branch names are not displayed properly
What did you expect to happen? (Expected behavior)
- Launching gitk, it should not crash and names like “🖤” should be
displayed correctly
What happened instead? (Actual behavior)
- Launching while on the branch “🖤” crashed gitk.
The reported error is:
X Error of failed request: BadLength (poly request too large or internal Xlib length error)
Major opcode of failed request: 139 (RENDER)
Minor opcode of failed request: 20 (RenderAddGlyphs)
Serial number of failed request: 5225
Current serial number in output stream: 5263
- Launching while on another branch but with the branch “🖤” makes that
branch appear as ⌷⌷
What's different between what you expected and what actually happened?
- gitk should launch and display Unicode characters correctly
[System Info]
git version:
git version 2.30.2
cpu: x86_64
no commit associated with this build
sizeof-long: 8
sizeof-size_t: 8
shell-path: /bin/sh
uname: Linux 5.11.11-200.fc33.x86_64 #1 SMP Tue Mar 30 16:53:32 UTC
2021 x86_64 compiler info: gnuc: 10.2
libc info: glibc: 2.32
$SHELL (typically, interactive shell): /bin/zsh
[Enabled Hooks]
