On Thu, Apr 15, 2021 at 8:34 AM Øystein Walle <oystwa@xxxxxxxxx> wrote: > A command such as `git push -qu origin feature` will print "Branch > 'feature' set up to track remote branch 'feature' from 'origin'." even > when --quiet is passed. In this case it's because install_branch_config() is > always called with BRANCH_CONFIG_VERBOSE. > > struct transport keeps track of the desired verbosity. Fix the above > issue by passing BRANCH_CONFIG_VERBOSE conditionally based on that. > > Signed-off-by: Øystein Walle <oystwa@xxxxxxxxx> > --- > diff --git a/t/t5523-push-upstream.sh b/t/t5523-push-upstream.sh > @@ -119,4 +119,11 @@ test_expect_success TTY 'quiet push' ' > +test_expect_success TTY 'quiet push -u' ' > + ensure_fresh_upstream && > + > + test_terminal git push --quiet -u --no-progress upstream main 2>&1 | tee output && > + test_must_be_empty output > +' I wondered why you used `tee` here since it adds no value (as far as I can tell), but I see that you copied it from the test preceding this one. So... [intentionally left blank]
