Re: [PATCH v6 04/20] reftable: utility functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 13, 2021 at 3:14 PM Ævar Arnfjörð Bjarmason
<avarab@xxxxxxxxx> wrote:
> I'd think that rather than duplicating magic constants & one thing in
> dir.h we'd be better off having some leading patches splitting off the
> relevant parts of object-file.c & dir.h, maybe THAT_NAME_minimal.h?
>
> Or: why not simply include dir.h and object.h etc? The compiler/linker
> will discard the unused functions, and if the worry is overuse of
> git.git functions creeping in I'd think that would be better done via
> some test/CI job that checks what objects were used.

It was useful to see how much (or how little) of Git I needed to make
it work, but it has served its purpose, so I followed your suggestion
to use dir.h and object.h.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux