On Tue, Apr 13, 2021 at 9:28 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > However, it is fundamentally blocked on someone willing to spend > > some time reviewing the series; this seems to be out of my > > control. > > I for one find it hard to follow re-rolls of this when past discussion > isn't clarified/updated in commit messages/CLs. > > So in particular in v3[2] there was a whole discussion about what what > this licence & external hosting of this codebase meant in practical > terms. > > I vaguely recall that that was clarified in some way by you, but didn't > find the relevant E-Mail. Something like Google's lawyers said something > to the effect that this could just be added to git.git, no? Maybe that's > incorrect, I don't remember. You're right, I didn't update the thread. The outcome is that the library for now lives in https://github.com/hanwen/reftable while it's not integrated in git.git. In this repo I can accept contributions (including fixup changes posted to the git list) without requiring CLAs. > I.e. if it's meant to be 100% externally maintained and "code-dumped" > into git.git like we do with sha1collisiondetection/ that raises one set > of concerns, but if it's meant to be "eaten" by git.git that poses > another set of questions for the code review here. I.e. much of what > you're doing in later patches in this series is introducing things that > are redundant/odd if viewed if we're supposing that this code is meant > to live in git.git. The code is meant to be eaten by git.git, but be amenable to being used by libgit2 with minimal modifications. To that end, it tries to use just functionality offered by git-compat-util. If you could point out specific oddities, that would be helpful. As said earlier, the BSD license here is the most liberal I could find, but I'm open to something else, if that makes integration in both git and libgit2 possible. This was not discussed further, and hence the "TODO: relicense?" comment. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
