On Wed, Mar 31 2021, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> test_expect_success 'can parse blob ending with CR' ' >> - printf "[some]key = value\\r" >config && >> - git add config && >> - git commit -m CR && >> + test_commit --printf CR config "[some]key = value\\r" && > > OK, the first arg becomes the commit title, and the second one is > used for the filename, and the next arg is the string given to > printf, I guess. > >> test_expect_success 'rerere forget (binary)' ' >> git checkout -f side && >> - printf "a\0c" >binary && >> - git commit -a -m binary && >> + test_commit binary binary "a\0c" && > > This lacks --printf. Are we breaking the test but "test-must-fail" > is hiding the breakage here? Yes, well spotted. FWIW in splitting this out into another series I fixed this bug in the re-roll: https://lore.kernel.org/git/cover-00.16-00000000000-20210412T110456Z-avarab@xxxxxxxxx/T/#ma9ef67d8198c203adc05aab44f87aa753a3df993
