This is a "various small fixes" series to test-lib.sh, test-lib-functions.sh. I have a couple of outstanding patch serieses that I've pulled this from (ab/describe-tests-fix, ab/pickaxe-pcre2), as well as some other local work I've been having a chicken and egg problem with. I think the approach of pulling out these various miscellaneous test fixes into their own topic makes the most sense, I'll then submit re-rolled versions of other topics that e.g. need these new test_commit arguments on top of this. Ævar Arnfjörð Bjarmason (16): check-non-portable-shell: complain about "test" a/-o instead of &&/|| test-lib: bring $remove_trash out of retirement test-lib tests: remove dead GIT_TEST_FRAMEWORK_SELFTEST variable test-lib-functions: reword "test_commit --append" docs test-lib-functions: document test_commit --no-tag test-lib functions: add an --annotated-tag option to "test_commit" describe tests: convert setup to use test_commit test-lib functions: add --printf option to test_commit submodule tests: use symbolic-ref --short to discover branch name test-lib: reformat argument list in test_create_repo() test-lib: do not show advice about init.defaultBranch under --verbose test-lib: modernize test_create_repo() function test-lib-functions: normalize test_path_is_missing() debugging test-lib-functions: use "return 1" instead of "false" Revert and amend "test-lib-functions: assert correct parameter count" test-lib-functions: remove last two parameter count assertions t/check-non-portable-shell.pl | 4 + t/lib-submodule-update.sh | 3 +- t/t0000-basic.sh | 4 - t/t1307-config-blob.sh | 4 +- t/t1403-show-ref.sh | 6 +- t/t2030-unresolve-info.sh | 3 +- t/t4006-diff-mode.sh | 6 +- t/t4030-diff-textconv.sh | 8 +- t/t5406-remote-rejects.sh | 1 - t/t5407-post-rewrite-hook.sh | 2 - t/t5409-colorize-remote-messages.sh | 1 - t/t5520-pull.sh | 10 +-- t/t6120-describe.sh | 58 +++---------- t/test-lib-functions.sh | 125 ++++++++++++++-------------- t/test-lib.sh | 36 ++++---- 15 files changed, 113 insertions(+), 158 deletions(-) -- 2.31.1.634.gb41287a30b0