Re: [PATCH 10/15] hash: provide per-algorithm null OIDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2021-04-11 at 14:03:05, Junio C Hamano wrote:
> "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes:
> 
> > diff --git a/object-file.c b/object-file.c
> > index 5f1fa05c4e..50bb5b6ca4 100644
> > --- a/object-file.c
> > +++ b/object-file.c
> > @@ -55,7 +55,6 @@
> >  	"\x6f\xe1\x41\xf7\x74\x91\x20\xa3\x03\x72" \
> >  	"\x18\x13"
> >  
> > -const struct object_id null_oid;
> >  static const struct object_id empty_tree_oid = {
> >  	EMPTY_TREE_SHA1_BIN_LITERAL,
> >  	GIT_HASH_SHA1,
> > @@ -64,6 +63,9 @@ static const struct object_id empty_blob_oid = {
> >  	EMPTY_BLOB_SHA1_BIN_LITERAL,
> >  	GIT_HASH_SHA1,
> >  };
> > +const struct object_id null_oid_sha1 = {
> > +	{0}, GIT_HASH_SHA1,
> > +};
> 
> sparse wants this to be a file-scope static.

Can do.
-- 
brian m. carlson (he/him or they/them)
Houston, Texas, US

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux