Re: EDITOR with tilde not expanded in git-commit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> Hi,
>
> On Tue, 28 Aug 2007, Randal L. Schwartz wrote:
>
>> >>>>> "Bill" == Bill Lear <rael@xxxxxxxxxx> writes:
>> 
>> Bill> I was told eval was "wrong on multiple levels".
>> 
>> I should elaborate.
>> 
>> Using "eval" here means that you *then* have to be careful about 
>> whitespace quoting.  For example, if my $HOME had a space in it, 
>> EDITOR="$HOME/bin/superemacs" would be broken if you add the extra eval, 
>> since the whitespace would be treated as a delimeter on the second 
>> lexing.  I'd have to figure out how to set EDITOR with the right quotes 
>> or backwhacks in it to undo the effect of your eval.
>
> Yes, I never felt good about our change in the EDITOR handling.

EDITOR="\"$HOME/bin/superemacs\" -nw"

It's like most of the rest of the world reads the EDITOR variable and
there is little point for git not to follow suit.  It has been tested
and discussed.  That you missed this because of your killfile
preferences is your personal choice.

> In related news, I don't see why Bill's colleague does not just
> change the broken ~ to the proper $HOME.

Quite so.  ~ is really something mostly for interactive use.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux