On Thu, Aug 28, 2007, Jon Smirl wrote: > On 8/28/07, Jakub Narebski <jnareb@xxxxxxxxx> wrote: >> On Thu, Aug 28, 2007, Jon Smirl wrote: >>> On 8/28/07, Jakub Narebski <jnareb@xxxxxxxxx> wrote: >> >>>> This for example allows to put email address in the project owner >>>> field in the projects index file (when $projects_list points to >>>> a file, and not to a directory), in the form of: >>> >>> hometext.html has the same problem. >>> >>> Also, hometext.html should be rename hometxt.xhtml, it uses xml >>> syntax not html. >> >> Actually it is _different_ problem, because while projects list file is >> meant to be *plain text* file with two space separated, URL-encoded >> strings per line, hometext.html (and header.html, gooter.html and per >> repository README.html) is meant as a *fragment* to insert on gitweb >> page, and of course it should follow the same syntax as main gitweb >> page. Which might be HTML, or might be XHTML. > > I tried adding an email address to hometext.html yesterday, I got the > same XML errors caused by the <> that I received in the project owner > field. Be it HTML or XHTML fragment, you have to escape '<' and '>' yourself, by using '<' and '&rt;' entities; if we HTML-escaped contents of hometext.html (BTW. the filename depends on build time configuration) we could not put for example links there... -- Jakub Narebski Poland - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
