Re: [BUG] gitweb on repo.or.cz shows buggy commitdiff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski wrote:
> Petr Baudis wrote:
>> On Mon, Aug 27, 2007 at 02:30:04AM CEST, Jakub Narebski wrote:
> 
>>> 2. Alternate solution is to note that we have split patch only
>>> in the case of 'T' (type change) status, and for typechange we
>>> always split patch in two, so there are two patches corresponding
>>> to single raw diff-tree line. 
> [...]
>> 
>> I'd prefer this solution, though I think split patch could also
>> happen if you use -B (which I think is very good idea to use and
>> it's a pity that it isn't default - or is it?).
> 
> No, 'B' status does not means split patch: it only affects how the
> patchset looks like, i.e first delete all then add all, instead of
> doing change chunk by chunk.

There is no 'B' status in raw tree output. Broken filepairs can be left
as pair of addition 'A' and deletion 'D', or merged into modification
with dissimilarity score, e.g. 'M064'.

See Documentation/diffcore.txt:

  the latest implementation always merges all the broken pairs
  back into modifications, but the resulting patch output is
  formatted differently for easier review in case of such
  a complete rewrite by showing the entire contents of old version
  prefixed with '-', followed by the entire contents of new
  version prefixed with '+'.


So only 'T' results in two patches for one raw diff line.

-- 
Jakub Narebski
Poland
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux