Re: EDITOR with tilde not expanded in git-commit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, August 28, 2007 at 08:16:27 (-0700) Randal L. Schwartz writes:
>>>>>> "Bill" == Bill Lear <rael@xxxxxxxxxx> writes:
>
>Bill> Of course, and one could use a full path also, but tilde is a
>Bill> perfectly valid replacement for $HOME,
>
>Only to a shell.  The kernel has no clue about it.  I'd even say "only
>to *some* shells" as well, but most modern shells now understand it.

Well it is certainly valid to a user to set their EDITOR in that way,
both in bash and zsh, so "only to a shell" is false, not even
considering that he works with this every day with plenty of other
tools, and has not seen a problem with them.  I do notice that
cvs pukes on this, however:

% cd bin
% ln -s /usr/bin/vim vingo
% cd ~/testo
% EDITOR="~/bin/vingo -C"
% cvs commit
cvs commit: cannot exec ~/bin/vingo: No such file or directory
cvs commit: warning: editor session failed

>Bill>  and I think git should support
>Bill> it, and not force the user to work around it.
>
>The eval solution is wrong on multiple levels.

Fine with me: that's why I brought it up and asked the question.  How
would you propose to fix it?  If git-commit were rewritten in C, I
can see an argument "C does not understand tilde", but I can't
see this as a valid argument for not supporting it.


Bill
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux